Remove wrappers of uppercase libmklsparse functions #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 24.86% 33.38% +8.51%
==========================================
Files 7 7
Lines 1693 1261 -432
==========================================
Hits 421 421
+ Misses 1272 840 -432 ☔ View full report in Codecov by Sentry. |
amontoison
approved these changes
Sep 16, 2024
|
@amontoison That was fast, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkl_spblas.h header contains definitions both for lower- and uppercase versions of each "classical" sparse BLAS routine.
There is no reason to wrap both versions, and MKLSparse.jl only uses the lowercase ones.
Removing uppercase defs halves the size of libmklsparse.jl.
Also, output_ignorelist of the wrapper.jl script is optimized by converting explicit strings to regexes.